Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in the modules #7

Open
lmouline opened this issue Oct 7, 2020 · 0 comments
Open

Consistency in the modules #7

lmouline opened this issue Oct 7, 2020 · 0 comments

Comments

@lmouline
Copy link

lmouline commented Oct 7, 2020

While implementing the prototype, I tried to make strict separation between the model and the different algorithms (load approximation, cycle funder, ...). The idea was that the model should not contain any data that is computed by an algorithm.

However, this is not a 1st design choice. So currently, there is a mix between this design choice and the previous one (algorithms that modify the model directly). It is the case, for example, for the UncertainLoad approximator

Those modules should be refactor to reflect the last design (or reflect the one selected while addressing #3 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants