-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: language changing broken? #8
Comments
I don't believe that @jublo implemented different example code blocks for different languages, just the JS specimen and option to enter your own, then highlight it to date. |
@tomByrer Chris is right, for now there are no additional code samples. Do you have any suitable ones in mind? |
Thanks for your interest!
|
@tomByrer Thanks for the effort you put into this! We’ll gladly take any code you can provide, but the better prepared, the less work for us! 😉 |
@jublo @tomByrer have a look at https://github.com/source-foundry/code-corpora We have a number of commonly used projects across common language types that we are using as the basis of our source code analysis to optimize Hack. Perhaps a place to pinch some code and get started? |
That looks great @chrissimpkins; exactly what I was looking for! |
I have been tossing around the idea of generating short code snippets for the most common programming languages as part of that repo that you linked Tom. Maybe a better approach would be to understand the common tokens that are used in each language and then find a way to display those along with commonly confused characters in each specimen. We can be creative. I think that this would be a great resource for others and would support the syntax highlighting in the ACE editor that JM developed here. |
That sounds like a good idea. |
@tomByrer Here is where we are pulling together the source code specimens https://github.com/source-foundry/code-corpora I've put together an early version of a script that analyzes the token frequency in each of the language types with the Python NLTK library and intend to expand on this analysis. This was prompted by our interest in a more objective approach to the optimization of the Hack typeface and we intend to use the results to guide upcoming changes to the Hack fonts. I think that the analysis will be very helpful for the development of a set of source code text specimen "standards" as well. We could place these out in the wild in an attempt to reach a consensus among the open source developer community. |
@chrissimpkins The confusedchar file looks good, especially in view of our discussions about backslashes, pipes etc. |
@jublo question is about implementation on Font Playground as a new specimen type |
@chrissimpkins Elaborate. |
@jublo see OP message and your post earlier in this thread. he suggested code for Font Playground |
@chrissimpkins Are we to swap sample code shown on editors once user changes selected language? |
@jublo Your font playground design. Please implement what you feel best, PR, and we will get it merged in. Code samples still exist in that code corpora repository if they are helpful. |
|
add
If you put them in the OP, you see the number of incomplete checklist tasks in the IR listing on Github. Not sure if that feature works from thread posts or not (we'll see after this is entered) :) |
@chrissimpkins Apparently thanks! |
When I change the language, nothing changes but the highlighting. Used to be different code examples were swapped?
Win & Linux, Chrome, Fx, IE
The text was updated successfully, but these errors were encountered: