Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superdataset citation contains html tags #92

Closed
adswa opened this issue Feb 28, 2024 · 3 comments
Closed

Superdataset citation contains html tags #92

adswa opened this issue Feb 28, 2024 · 3 comments

Comments

@adswa
Copy link

adswa commented Feb 28, 2024

Clicking the "Cite" button in https://data.sfb1451.de/dataset/e132ac40-30c5-457d-8c7c-0dcbdbb95d9a/907e4d5ed5ddc033a5ba167bff83abbfcff2b60d shows <i> HTML tags:

image
@mslw
Copy link
Collaborator

mslw commented Feb 28, 2024

I think this is a behavior we inherit from DataLad-Catalog and, in a way, DataCite and its CSL processor.

AFAIK, the "cite" button is shown if dataset metadata includes a DOI. When clicked, the JS code fetches a response from https://doi.org/... with header set to Accept: "text/x-bibliography; style=apa", and shows the response text.

I'm pretty sure the title in Zenodo does not contain any formatting markers (also, Zenodo displays its own citation without markup), so my guess is the <i> tags are coming from Crosscite (who are the DOI registration agency). This is what the response looks like with a plain curl call (it contains the tags):

❱ curl -L -H "Accept: text/x-bibliography; style=apa" https://doi.org/10.5281/zenodo.10556115
Fink, G., Aswendt, M., Baldermann, J. C., Bender, S., Bergami, M., Büschges, A., Daun, S., Drzezga, A., Erhardt, E., Eickhoff, S., Gatto, G., Grefkes, C., Hanke, M., Hönig, M., Isbrandt, D., Ito, K., Jessen, F., Kloppenburg, P., Kononenko, N., … Wirth, B. (2024). <i>SFB1451 - key mechanisms of motor control in health and disease</i> (Version v20240124) [Data set]. Zenodo. https://doi.org/10.5281/ZENODO.10556115

As a side note - I was more worried about the thing being reported (in your screenshot) as [computer software]. I fixed it by hand on Zenodo and the citations are now produced correctly as [data set]. I'm not sure if it was due to zenodo not picking type: dataset from our CFF file, or due to my mistake when registering the dataset with Zenodo, but it is worth paying attention to whenever I'm cutting a new "release".

Given that the citation is shown as verbatim text, I think we could patch the JS code for this catalog instance to strip html formatting from the response (ideas in this SO post). Is that what you suggest?

@jsheunis
Copy link
Collaborator

@mslw your analysis and suggestions make sense to me. Makes sense to fix in datalad-catalog core too.

@jsheunis jsheunis mentioned this issue Apr 10, 2024
Closed
@jsheunis
Copy link
Collaborator

This issue can be closed once the latest changes from upstream is merged here, since it was addressed in datalad/datalad-catalog#440

mslw added a commit that referenced this issue Apr 30, 2024
@mslw
Apply changes from catalog upstream
4aec3ec 
Changes introduced in catalog upstream were introduced by running
`datalad catalog-create -c docs --force` and using Git to stage or
discard specific changes.

The only file which needed staging in chunks was index.html, and one
property had to be added to the config file by hand (catalog_url).

This uses:
datalad/datalad-catalog/commit/821b12f51302b9a830dee00ac5f4f247aed0532e

Closes #93, fixes #92, fixes #88
@mslw mslw closed this as completed in e6a2f92 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsheunis @mslw @adswa