Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw - Do not allow post reordering #261

Closed
wants to merge 1 commit into from
Closed

Withdraw - Do not allow post reordering #261

wants to merge 1 commit into from

Conversation

P-U-D-G-E
Copy link
Collaborator

@P-U-D-G-E P-U-D-G-E commented Sep 26, 2023 •
edited
Loading

Description

Do not allow withdrawal for a participation if reordering has occurred.

Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation

Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@P-U-D-G-E P-U-D-G-E requested a review from a team as a code owner September 26, 2023 21:11
scorpioborn
scorpioborn requested changes Sep 27, 2023
View reviewed changes
x/orderbook/keeper/participation.go
@@ -189,6 +189,17 @@ func (k Keeper) CalcWithdrawalAmount(
return sdkmath.Int{}, sdkerrors.Wrapf(types.ErrMismatchInDepositorAddress, "%s", bp.ParticipantAddress)
}

bpE, err := k.GetExposureByOrderBookAndParticipationIndex(ctx, marketUID, participationIndex)
if err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be merged with 196 as follows:

if err != nil || len(bpE) == 0 {
...
}

also a comment would be nice to understand what are these check for

@3eyedraga 3eyedraga closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scorpioborn scorpioborn scorpioborn requested changes

@3eyedraga 3eyedraga Awaiting requested review from 3eyedraga

Assignees
No one assigned
Labels
C:x/orderbook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P-U-D-G-E @scorpioborn @3eyedraga