Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Rounding of the truncated values #266

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Oct 10, 2023

Description

Current implementation tries to truncate the calculated bet amount value of the expected payout, this creates negative bet amounts if a large number of deposits are done. This PR tries to change the truncation to rounding.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Bet amount calculation from payout

Test Cases

  • TestWagerLargeNumbers

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@3eyedraga 3eyedraga merged commit 635bb89 into sge-network:master Oct 10, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants