Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Campaign missing funds input in CLI #302

Merged

Conversation

scorpioborn
Copy link
Contributor

Description


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@scorpioborn scorpioborn requested a review from a team as a code owner November 16, 2023 11:54
@github-actions github-actions bot added the C:CLI label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9f4f854) 11.91% compared to head (cd0d517) 11.91%.
Report is 2 commits behind head on feature/rewards.

Files Patch % Lines
x/reward/types/messages_campaign.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/rewards     #302      +/-   ##
===================================================
- Coverage            11.91%   11.91%   -0.01%     
===================================================
  Files                  343      343              
  Lines                44006    44008       +2     
===================================================
  Hits                  5245     5245              
- Misses               38288    38290       +2     
  Partials               473      473              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3eyedraga 3eyedraga merged commit 1b809c9 into sge-network:feature/rewards Nov 16, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants