Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Upgrade Handler v1.3.0 #325

Merged

Conversation

scorpioborn
Copy link
Contributor

Description

Implement v4 upgrade handler for the reward and subaccount.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Reward module added to upgrade handler
  • Subaccount module added to upgrade handler
  • Params query added to subaccount module

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (87db989) 11.83% compared to head (956cd6a) 11.83%.

Files Patch % Lines
x/subaccount/types/query.pb.go 0.00% 10 Missing ⚠️
x/subaccount/keeper/query_params.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   11.83%   11.83%           
=======================================
  Files         346      347    +1     
  Lines       44417    44417           
=======================================
  Hits         5257     5257           
  Misses      38679    38679           
  Partials      481      481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3eyedraga 3eyedraga merged commit a8eff24 into sge-network:master Dec 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants