Skip to content

Commit

Permalink
Insert workaround for failing test
Browse files Browse the repository at this point in the history
  • Loading branch information
aleino-nv committed Dec 5, 2024
1 parent 3dcfb3d commit fc18647
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion source/slang/slang-ir-legalize-global-values.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ void GlobalInstInliningContextGeneric::inlineGlobalValuesAndRemoveIfUnused(IRMod

// Since certain globals that appear in the IR are considered illegal for all targets,
// e.g. calls to functions, we delete globals which no longer have uses after inlining.
if (!inst->hasUses())
// TODO: Explain why tests/spirv/global-compute.slang fails if we don't exclude kIROp_SPIRVAsm
if (!inst->hasUses() && inst->getOp() != kIROp_SPIRVAsm)
inst->removeAndDeallocate();
}
}
Expand Down

0 comments on commit fc18647

Please sign in to comment.