-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove out of scope tests from wgsl failed test list. #5519
Labels
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Comments
csyonghe
added
the
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
label
Nov 7, 2024
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this issue
Nov 20, 2024
Some tests are now passing and are enabled. Other tests are still failing, but are given comments categorizing the failures. Tests in the 'Not supported in WGSL' category are also removed from the expected failures list. (Though they are still kept disabled for WebGPU, of course.) This closes shader-slang#5519.
|
Now we have 19 disabled tests that we aren't planning to address, and 14 disabled tests that we should address. So totally we have 33 disabled tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
Many of the remaining WGSL "failures" are expected and out of the capability of WGSL, and we should just keep the DISABLED_TEST in the test files, and remove them from expected failure list.
We need to identify these tests. They should all fall into one the following cateogories:
Let's remove the tests that falls into one of the above categories from the list, and work towards reducing that list to 0.
The text was updated successfully, but these errors were encountered: