Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTS] VK-CTS regression: dEQP-VK.ubo.2_level_array.std140.row_major_mat2.vertex #5840

Open
jkwak-work opened this issue Dec 11, 2024 · 3 comments
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:regression

Comments

@jkwak-work
Copy link
Collaborator

The following VK-CTS tests started failing from this morning.

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.vertex'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.fragment'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.both'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.vertex_comp_access'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.fragment_comp_access'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.both_comp_access'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.column_major_mat2.vertex'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.column_major_mat2.fragment'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.column_major_mat2.both'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.column_major_mat2.vertex_comp_access'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.column_major_mat2.fragment_comp_access'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

Test case 'dEQP-VK.ubo.2_level_array.std140.column_major_mat2.both_comp_access'..
Failed to generate SPIRV ouptput from test-server results: 80004005
  InternalError (Compiling GLSL to SPIR-V failed at vkPrograms.cpp:701)

The failure was observe from a nightly VK-CTS run:
https://github.com/shader-slang/slang/actions/runs/12271349271

It appears that this regression is from
#5807

The PR adds error reporting on unrecognized layout qualifiers, so it is expected to break glsl code that contains layout that slang doesn't know about.

We need to decide whether we want to disable those failing tests or fix the issue on Slang side.

@jkwak-work jkwak-work self-assigned this Dec 11, 2024
@jkwak-work jkwak-work added kind:regression goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels Dec 11, 2024
@jkwak-work
Copy link
Collaborator Author

The error message is following,

Test case 'dEQP-VK.ubo.2_level_array.std140.row_major_mat2.vertex'..
test.slang.vert(9): error 31217: GLSL layout qualifier is unrecognized or requires assignment
layout(set = 0, binding = 0, std140, row_major) uniform Block
                                     ^~~~~~~~~

It appears that row_major is not recognized by Slang.

I am going to disable the failing tests for now and we will keep track of the issue here.

@jkwak-work
Copy link
Collaborator Author

12 VK-CTS tests are disabled.
We should re-enabled them when we properly support row_major layout keyword.

@jkwak-work jkwak-work removed their assignment Dec 12, 2024
@jkwak-work
Copy link
Collaborator Author

I was looking at the first 12 failures but it turned out that there were total of 812 failing tests for the same reason.
Disabling the rest of the failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:regression
Projects
None yet
Development

No branches or pull requests

1 participant