Enable core module embedding by default in CMake. #5644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that release workflows were unexpectedly broken when STDLIB was renamed to CORE_MODULE.
Changed the option default because I think it just makes more sense. Removed explicit calls to enable it. Fixed docs.
Should
SLANG_EMBED_CORE_MODULE_SOURCE
be disabled too? Does it do anything useful?As reported in #5631
NOTE: I haven't really tested it at this point, but should work.