Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable core module embedding by default in CMake. #5644

Merged

Conversation

kanashimia
Copy link
Contributor

@kanashimia kanashimia commented Nov 22, 2024

It seems that release workflows were unexpectedly broken when STDLIB was renamed to CORE_MODULE.
Changed the option default because I think it just makes more sense. Removed explicit calls to enable it. Fixed docs.

Should SLANG_EMBED_CORE_MODULE_SOURCE be disabled too? Does it do anything useful?

As reported in #5631

NOTE: I haven't really tested it at this point, but should work.

It seems that release workflows were unexpectedly broken when STDLIB
was renamed to CORE_MODULE.
Changed the option default because I think it just makes more sense.
Removed explicit calls to enable it. Fixed docs.
@kanashimia kanashimia requested a review from a team as a code owner November 22, 2024 17:03
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@csyonghe
Copy link
Collaborator

The only reason to enable SLANG_EMBED_CORE_MODULE_SOURCE is so that the language server can provide useful documentation in hovering hints. We could disable this for most builds, and enable it only when building for language server, but that likely needs to come as its own PR. We can change the language server code to fetch the core module source from a separately deployed file that ships with slangd in the vs extensions, and get rid of this embeding in slang.dll to reduce binary size.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Nov 22, 2024
@jkwak-work
Copy link
Collaborator

I appreciate fixing the mistake I made.
I guess I didn't carefully check directories whose name starts with dot, "."

@csyonghe csyonghe merged commit 8e28e51 into shader-slang:master Nov 22, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants