Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SPIRV submodules #5815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkwak-work
Copy link
Collaborator

Closes #5573

One of tests started failing with the latest SPIR-V submodules:
tests/gpu-feature/texture/query/footprint/nv-shader-texture-footprint.slang

[ForceInline] is added to GLSL texture functions in order to inline %true and %false.
Without it, the value was indirectly passed down via a function parameter, which broke the existing test.

Also the test is modified to use -DAG, because the order unpredictably changed for Grad variants due to additional [ForceInline] marks for Gradient functions.

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Dec 10, 2024
@jkwak-work jkwak-work requested a review from cheneym2 December 10, 2024 00:45
@jkwak-work jkwak-work self-assigned this Dec 10, 2024
@jkwak-work jkwak-work requested a review from a team as a code owner December 10, 2024 00:45
@csyonghe
Copy link
Collaborator

The test still has validation error on linux and macos?

@jkwak-work
Copy link
Collaborator Author

I will work on the CI failures on Linux and MacOS

@jkwak-work
Copy link
Collaborator Author

It turned out that the Windows build is also not working properly.
The cause of the failure is that the test starts having a Vulkan Validation Error, which was introduced three month ago in SPIRV-Tools repo:
KhronosGroup/SPIRV-Tools@7ba72f1
The description of the commit is here,

spirv-val: Disallow stores according to VUID 06924 (https://github.com/KhronosGroup/SPIRV-Tools/pull/5368)
Ensure that the validator rejects stores to objects of types
`OpTypeImage`, `OpTypeSampler`, `OpTypeSampledImage`,
`OpTypeAccelerationStructureKHR`, and arrays of these types, according
to `VUID-StandaloneSpirv-OpTypeImage-06924`.

Guard the check behind the before_hlsl_legalization option, as
sometimes we may have temporaries or local variables that are expected
to get optimized away.

I will file an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SPIRV submodules to include "Update SPV_AMDX_shader_enqueue"
2 participants