Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad UX with asset search in swapper. #8139

Closed
0xean opened this issue Nov 18, 2024 · 6 comments · Fixed by #8175
Closed

Bad UX with asset search in swapper. #8139

0xean opened this issue Nov 18, 2024 · 6 comments · Fixed by #8175
Assignees
Labels
bug Something isn't working

Comments

@0xean
Copy link
Contributor

0xean commented Nov 18, 2024

In the swapper we currently don't show USDC as a pinned asset on the top, when a user attempts to search for it we suggest really bad first options for USDC, and the actual USDC is buried in the search.

Screenshot 2024-11-18 at 6 36 58 AM

A user has to

  1. know that the first USDC we suggest isn't the correct one, because they wont get any rates back with whatever spam token that actually is.

  2. scroll down three full pages to find USDC on ethereum
    Screenshot 2024-11-18 at 6 38 01 AM

  3. scroll past several other chain suggestions for USDC even tho the chain selector has ETH selected AND the wallet has ETH selected.

We should solve this. My suggestions would be

  1. pin USDC to the top just like USDT
  2. determine a better sorting algo for assets ( can we use market cap / trade volume or some other metric to better sort assets that match search criteria)
  3. Show assets on the currently connected chain and selected chain in the swapper first. (USDC on ETH shows up ahead of USDC on polygon for example)
@0xean
Copy link
Contributor Author

0xean commented Nov 18, 2024

cc @shapeshift/product

@twblack88
Copy link
Contributor

twblack88 commented Nov 18, 2024

wondering how much overlap with #7900

  • probably need to sort by marketcap
  • balance above some arbitrary number

@0xean 0xean added the bug Something isn't working label Nov 18, 2024
@0xean
Copy link
Contributor Author

0xean commented Nov 18, 2024

This is gonna be high prio - we can discuss during grooming, but the USDC assets we are suggesting PAGES ahead of the real assets are scam / spam tokens.

@0xean
Copy link
Contributor Author

0xean commented Nov 18, 2024

for this ticket:

Sort order in search:

  • Assets with fiat balance
  • Assets sorted by market cap (from asset generation)
  • Asset with non zero balance but zero fiat value (sort alphabetically)

Remove 0 mcap tokens from asset metadata
Add mcap to asset metadata from script and presort to avoid the need to do this at runtime
array needed for order of asset ids

longer term:

  • add hide list for assets
  • pair down search within swapper to remove more esoteric items w no MC that still may be desireable from portals
    • filter that allows for low caps in search (default to not include low or no mc tokens)
  • add warning to confirm user wants to interact with a low mcap token

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Nov 18, 2024
@0xApotheosis
Copy link
Contributor

0xApotheosis commented Nov 19, 2024

For posterity, the reason we don't necessarily show USDC as a pinned asset is because this list is dynamic.

We have useGetPopularAssetsQuery which calls getMarketServiceManager().findAllSortedByVolumeDesc() - we then dynamically pin the top 5 (either by chain, or overall if "All" is selected).

@0xean
Copy link
Contributor Author

0xean commented Nov 19, 2024

@0xApotheosis - thanks for that, forgot to add that to the scope of this during grooming, but will add a separate ticket for this.

@NeOMakinG NeOMakinG self-assigned this Nov 20, 2024
@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Nov 20, 2024
@NeOMakinG NeOMakinG moved this from In progress to In review in ShapeShift Dashboard Nov 22, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants