Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprioritize rates without gas fees #8143

Open
gomesalexandre opened this issue Nov 19, 2024 · 0 comments
Open

Deprioritize rates without gas fees #8143

gomesalexandre opened this issue Nov 19, 2024 · 0 comments

Comments

@gomesalexandre
Copy link
Contributor

Overview

Raised by @0xApotheosis in #8079 (review):

One thought on this whilst testing: in cases where we don't have a gas estimate on rate fetch (e.g. for Portals), in this branch we unfairly list that swapper above other swappers that do have a gas estimate.

In the example below LiFi is actually a much better rate overall (very low gas vs what Portals will end up being), but it ranks below Portals.

And indeed, not knowing network fees (as in, undefined unknown network fees vs. 0 explicit network fees e.g CoW) means the gas could make a given rate a lot worse for users in the end.

This PR is to ensure we deprioritize rates with unknown gas estimates.

References and additional details

#8079

Acceptance Criteria

  • Rates with undefined network fees are deprioritized in profit of rates which may seem better at first glance but may be worse given unknown fees i.e Portals atm

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant