You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One thought on this whilst testing: in cases where we don't have a gas estimate on rate fetch (e.g. for Portals), in this branch we unfairly list that swapper above other swappers that do have a gas estimate.
In the example below LiFi is actually a much better rate overall (very low gas vs what Portals will end up being), but it ranks below Portals.
And indeed, not knowing network fees (as in, undefined unknown network fees vs. 0 explicit network fees e.g CoW) means the gas could make a given rate a lot worse for users in the end.
This PR is to ensure we deprioritize rates with unknown gas estimates.
Rates with undefined network fees are deprioritized in profit of rates which may seem better at first glance but may be worse given unknown fees i.e Portals atm
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered:
Overview
Raised by @0xApotheosis in #8079 (review):
And indeed, not knowing network fees (as in, undefined unknown network fees vs. 0 explicit network fees e.g CoW) means the gas could make a given rate a lot worse for users in the end.
This PR is to ensure we deprioritize rates with unknown gas estimates.
References and additional details
#8079
Acceptance Criteria
undefined
network fees are deprioritized in profit of rates which may seem better at first glance but may be worse given unknown fees i.e Portals atmNeed By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered: