Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "pastel set luminance" #89

Open
sharkdp opened this issue Sep 2, 2019 · 0 comments
Open

Add "pastel set luminance" #89

sharkdp opened this issue Sep 2, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sharkdp
Copy link
Owner

sharkdp commented Sep 2, 2019

This is not as straightforward to implement like the rest of the properties. The way this should be implemented is probably by (only) adjusting the Lightness channel in Lab space until the luminance has the right value.

If there is no direct way to compute the correct L value, we could also perform a (binary) search in L space until we have the right luminance value.
@sharkdp sharkdp added enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2019
@JuanPotato JuanPotato mentioned this issue Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add set luminance using a binary search JuanPotato/pastel
1 participant
@sharkdp