Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating BOLT12 offers no longer working for Core Lightning v22.11 (SOLVED) #205

Open
hMsats opened this issue Dec 2, 2022 · 2 comments
Open

Generating BOLT12 offers no longer working for Core Lightning v22.11 (SOLVED) #205

hMsats opened this issue Dec 2, 2022 · 2 comments

Comments

@hMsats
Copy link

hMsats commented Dec 2, 2022 •
edited
Loading

Creating a bolt12 in spark-wallet is no longer working for the latest core lightning release.

IS SPARK-WALLET STILL BEING MAINTAINED???
@hMsats hMsats mentioned this issue Dec 4, 2022
Closed
@hMsats hMsats changed the title Latest Core Lighting uses invreq_payer_note instead of payer_note BOLT12 offers no longer working for Core Lightning v22.11 Dec 26, 2022
@hMsats hMsats changed the title BOLT12 offers no longer working for Core Lightning v22.11 Generating BOLT12 offers no longer working for Core Lightning v22.11 Dec 26, 2022
@ulrichard
Copy link

would be cool, if this worked again.

@hMsats
Copy link
Author

hMsats commented Apr 14, 2023 •
edited
Loading

I couldn't find the error and looked at it with my (genius) son. The breaking change in Core Lightning is here. The variable bolt12_unsigned was removed while spark-wallet still expects it. So we have to change bolt12_unsigned into just bolt12. This needs to be done in client/src/views/util.js and client/src/views/offers.js. Created a pull request. @ulrichard hope this solves it for you as well!

@hMsats hMsats changed the title Generating BOLT12 offers no longer working for Core Lightning v22.11 Generating BOLT12 offers no longer working for Core Lightning v22.11 (SOLVED) Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulrichard @hMsats