diff --git a/CHANGES.md b/CHANGES.md index e72a16f0..5c24671e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -11,6 +11,8 @@ ## develop +- [CHANGE] SoraAudioSource.on_data, SoraVideoSource.on_captured, SoraVAD.analyze の引数名を変更 + - @tnoho - [UPDATE] SoraMediaTrack を追加し、 SoraConnection.on_track の引数を SoraMediaTrack に変更 - @tnoho - [ADD] 発話区間の検出が可能な SoraVAD の追加 diff --git a/src/sora_sdk_ext.cpp b/src/sora_sdk_ext.cpp index 44cf7578..483bcf38 100644 --- a/src/sora_sdk_ext.cpp +++ b/src/sora_sdk_ext.cpp @@ -182,35 +182,43 @@ NB_MODULE(sora_sdk_ext, m) { .def_prop_ro("stream_id", &SoraMediaTrack::stream_id); nb::class_(m, "SoraAudioSource") - .def("on_data", nb::overload_cast( - &SoraAudioSource::OnData)) .def("on_data", - nb::overload_cast(&SoraAudioSource::OnData)) + nb::overload_cast( + &SoraAudioSource::OnData), + "data"_a, "samples_per_channel"_a, "timestamp"_a) + .def("on_data", + nb::overload_cast(&SoraAudioSource::OnData), + "data"_a, "samples_per_channel"_a) .def("on_data", nb::overload_cast, nb::c_contig, nb::device::cpu>, - double>(&SoraAudioSource::OnData)) + double>(&SoraAudioSource::OnData), + "ndarray"_a, "timestamp"_a) .def("on_data", nb::overload_cast, nb::c_contig, nb::device::cpu>>( - &SoraAudioSource::OnData)); + &SoraAudioSource::OnData), + "ndarray"_a); nb::class_(m, "SoraVideoSource") .def( "on_captured", nb::overload_cast, nb::c_contig, nb::device::cpu>>( - &SoraVideoSource::OnCaptured)) + &SoraVideoSource::OnCaptured), + "ndarray"_a) .def( "on_captured", nb::overload_cast, nb::c_contig, nb::device::cpu>, - double>(&SoraVideoSource::OnCaptured)) + double>(&SoraVideoSource::OnCaptured), + "ndarray"_a, "timestamp"_a) .def( "on_captured", nb::overload_cast, nb::c_contig, nb::device::cpu>, - int64_t>(&SoraVideoSource::OnCaptured)); + int64_t>(&SoraVideoSource::OnCaptured), + "ndarray"_a, "timestamp_us"_a); nb::class_(m, "SoraAudioSinkImpl", nb::type_slots(audio_sink_slots)) @@ -256,7 +264,7 @@ NB_MODULE(sora_sdk_ext, m) { nb::class_(m, "SoraVAD") .def(nb::init<>()) - .def("analyze", &SoraVAD::Analyze); + .def("analyze", &SoraVAD::Analyze, "frame"_a); nb::class_(m, "SoraVideoFrame") .def("data", &SoraVideoFrame::Data, nb::rv_policy::reference);