AssertListItem: fix passing incorrect item type to inner validator #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
force-pushed
the
fix-assert-item
branch
from
f162717
to
599e594
Compare
JanTvrdik
changed the title
JanTvrdik
force-pushed
the
fix-assert-item
branch
from
599e594
to
4c9dbe7
Compare
janedbal
reviewed
Aug 14, 2023
janedbal
reviewed
Aug 14, 2023
| 'ShipMonk\InputMapper\Runtime\Optional', | ||
| 0, | ||
| 'Countable & Traversable', | ||
| ]; |
There was a problem hiding this comment.
Can you add testcase with something similar to this? phpstan/phpstan#9198
There was a problem hiding this comment.
I'm not sure what you mean. There is case for union.
yield [
'list<int>|list<string>',
'list',
0,
'int|string',
];There is no normalization for unions for now. But it you ask what is the value type of list<int>|list<string>, the answer has to be int|string which is an information loss. To avoid loosing the information, you must never pass union to inferGenericParameter and handle the union on the caller side. But that is not always pratical.
janedbal
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.