Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional state informationen #7

Open
pascalberger opened this issue May 6, 2016 · 6 comments
Open

Add additional state informationen #7

pascalberger opened this issue May 6, 2016 · 6 comments

Comments

@pascalberger
Copy link
Contributor

It would be useful if more state information about the PR can be shown:

  • Reviewer approval state
  • State of work item link policy
  • State of build policy
@pascalberger
Copy link
Contributor Author

I don't know if this is possible though with the current API as these information seem to be missing on the gitpullrequest object

@pascalberger
Copy link
Contributor Author

And related to that is the "Request status" column of any use? Since it only shows active requests anyway won't it always print "Active" there?

IMHO it would be nice to have one flag indicating if the PR is ready to being merged (red / green indicator) with maybe a tooltip showing the details (approval state, policy state)

@sierpinski
Copy link
Owner

This is a great idea! Brilliant! I will have to research how to get that data, but I love the idea of a single state flag. I'm thinking we load this, and the repository name, after page load asynchronously, so the page loads quickly and slowly updates the page as the info comes in. Thanks by the way for the contributions. I'm just one person, so I love the help!

@pascalberger
Copy link
Contributor Author

@sierpinski Also maybe using Contextual classes on the table rows to indicate their readiness might be useful.

@sierpinski
Copy link
Owner

I haven't been able to address most of these yet. I did remove the Request Status field. I also added colors and tooltips on reviewers for now, to indicate how they have responded to the request. When I can, I'll look at the policies to see if we can get that info.

@Russweb
Copy link

Russweb commented Nov 17, 2016

+1 on those states for me too.
To make it really dynamic (not sure if possible or not), but the color-coding would be based on whether all required rules are satisfied.
In other words, if it requires a CI build, 2 approvers, and associated work items, then the row is red until all those are met.
Does the API have the ability to pick those out yet?

I filed a bug on this:
https://connect.microsoft.com/VisualStudio/feedback/details/3111792/tfs-15-rest-api-for-pull-request-missing-overall-status-function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants