-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional state informationen #7
Comments
I don't know if this is possible though with the current API as these information seem to be missing on the gitpullrequest object |
And related to that is the "Request status" column of any use? Since it only shows active requests anyway won't it always print "Active" there? IMHO it would be nice to have one flag indicating if the PR is ready to being merged (red / green indicator) with maybe a tooltip showing the details (approval state, policy state) |
This is a great idea! Brilliant! I will have to research how to get that data, but I love the idea of a single state flag. I'm thinking we load this, and the repository name, after page load asynchronously, so the page loads quickly and slowly updates the page as the info comes in. Thanks by the way for the contributions. I'm just one person, so I love the help! |
@sierpinski Also maybe using Contextual classes on the table rows to indicate their readiness might be useful. |
I haven't been able to address most of these yet. I did remove the Request Status field. I also added colors and tooltips on reviewers for now, to indicate how they have responded to the request. When I can, I'll look at the policies to see if we can get that info. |
+1 on those states for me too. I filed a bug on this: |
It would be useful if more state information about the PR can be shown:
The text was updated successfully, but these errors were encountered: