Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User enumeration #31

Open
michaelsproul opened this issue Oct 11, 2023 · 0 comments
Open

User enumeration #31

michaelsproul opened this issue Oct 11, 2023 · 0 comments

Comments

@michaelsproul
Copy link
Member

Currently it's possible to enumerate client JWT secret IDs by providing an invalid JWT with a key ID. If the key ID exists, then the error will be one about the secret being invalid, whereas if it doesn't exist, it will be an error about no matching key being found:

eleel/src/jwt.rs

Lines 71 to 72 in f164b02

// No matching key found.
Err("No matching JWT secret found".into())

To prevent client enumeration we should ensure the error is the same in these two cases.

Thanks @chong-he for testing and finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant