-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consensus version to submitBlindedBlock
request header
#4284
Comments
hey @jimmygchen , is this related to #4525 ? |
This is a different one, this is for the We currently don't send this HTTP header in the request, and is an optional header in the spec that would make it easier for the builder to deserialize the request body. sequenceDiagram
participant validator
participant beacon_node
participant mev_boost
Title: Block Proposal with Builder API
validator->>beacon_node: GET v2/validator/blinded_blocks/{slot}
beacon_node->>mev_boost: GET v1/builder/header/{slot}/{parent_hash}/{pubkey}
mev_boost-->>beacon_node: returns bid & blinded payload
beacon_node-->>validator: returns blinded block
Note over validator: signs the blinded block
validator->>beacon_node: POST beacon/blinded_blocks
beacon_node->>mev_boost: POST /eth/v2/builder/blinded_blocks
Note right of beacon_node: sends signed blinded beacon block
mev_boost-->>beacon_node: returns revealed payload
Note over beacon_node: construct block and broadcast block
|
hey @jimmygchen, how do I get access to some object of
It is required to get fork version here:
|
Hi @Gua00va
lighthouse/beacon_node/http_api/src/publish_blocks.rs Lines 267 to 277 in 071dd4c
and then pass it to the |
I think this is probably not super useful unless the header is mandatory, perhaps revisit this if a new v2 version of the endpoint is added with SSZ support. |
Closing this. See comment above. |
I think we actually implemented this header recently off the back of a bug report by JGM: Impl in: |
Nice! |
Description
Consider providing fork name via a
Eth-Consensus-Version
HTTP header when sendingsubmitBlindedBlock
request to remote builder. (or potentially all remote builder requests?)This change has been included in
builder-specs
v0.3.0, although it's an optional tag:https://github.com/ethereum/builder-specs/blob/7b269305e1e54f22ddb84b3da2f222e20adf6e4f/apis/builder/blinded_blocks.yaml#L15
This header would help the endpoint provider (relays) discriminate the type the request payload when decoding.
The text was updated successfully, but these errors were encountered: