Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger unknown parent lookups from RPC blob processing #5660

Open
realbigsean opened this issue Apr 30, 2024 · 0 comments
Open

Trigger unknown parent lookups from RPC blob processing #5660

realbigsean opened this issue Apr 30, 2024 · 0 comments
Labels
deneb

Comments

@realbigsean
Copy link
Member

Description

The logic in #5655 delays blobs for processing until we've processed a corresponding block in order to allow that to trigger an unknown parent lookup. This can be adjusted if unknown parent lookups can be triggered by RPC blobs.

Add the following checks to RPC blob processing:

  • parent block is known
  • slot is not in the future
@realbigsean realbigsean mentioned this issue Apr 30, 2024
Merged
michaelsproul added a commit that referenced this issue Apr 30, 2024
@michaelsproul
Merge parent and current sync lookups (#5660)
0d5c21a 
Squashed commit of the following:

commit 0203843
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 30 15:14:30 2024 +0900

    Various fixes

commit 9d185d1
Author: realbigsean <seananderson33@GMAIL.com>
Date:   Tue Apr 30 01:59:05 2024 -0400

    #5655 pr review (#26)

    * fix compile after merge

    * remove todos, fix typos etc

    * fix compile

    * stable rng

    * delete TODO and unfilled out test

    * make download result a struct

    * enums instead of bools as params

    * fix comment

commit 4bde25b
Author: realbigsean <seananderson33@GMAIL.com>
Date:   Mon Apr 29 21:29:55 2024 -0400

    fix compile after merge

commit c309c07
Merge: 13bc011 c8ffafb
Author: realbigsean <seananderson33@GMAIL.com>
Date:   Mon Apr 29 21:29:29 2024 -0400

    Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup

commit 13bc011
Merge: bad87b1 8b24880
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Sat Apr 27 12:16:29 2024 +0900

    Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup

commit bad87b1
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Fri Apr 26 10:32:23 2024 +0900

    Merge current and parent lookups tests

commit 5d29618
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Thu Apr 25 21:59:22 2024 +0900

    Merge current and parent lookups clean up todos

commit 611c37a
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Wed Apr 24 08:52:06 2024 +0900

    Merge current and parent lookups

commit 3b662de
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 23 15:14:17 2024 +0900

    Send parent blocks one by one

commit 4c8143f
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 23 01:28:53 2024 +0900

    Drop reconstructed for processing

commit e0b862b
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 23 01:14:26 2024 +0900

    Drop lookup type trait for a simple arg
@chong-he chong-he added the deneb label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deneb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@realbigsean @chong-he