Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3signer doesn't set appropriate headers to indicate that json is an acceptable response #5691

Closed
lrusak opened this issue May 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lrusak
Copy link
Contributor

lrusak commented May 2, 2024

Description

The web3signer doesn't set the applicable Accept header to indicate that application/json is an acceptable response.

the web3signer api indicates that both application/json and text/plain are acceptable response types for signing requests.

The web3signer handler in lighthouse requires a json response. Setting the header "Accept: application/json" indicates to the web3signer that json is an acceptable response.

The default header uses Accept: */* which means any response is acceptable.

Version

stable (v5.1.3)

Present Behaviour

Fail to deserialize response as json if the respnse return type is plain/text.

Expected Behaviour

Properly deserialize the json response

Steps to resolve

Set the correct header for the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants