Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-operation block processing metrics #5999

Open
realbigsean opened this issue Jun 26, 2024 · 3 comments
Open

Add per-operation block processing metrics #5999

realbigsean opened this issue Jun 26, 2024 · 3 comments
Labels
good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does!

Comments

@realbigsean
Copy link
Member

Description

We have metrics for block processing but it would be good to add some granularity as we continue to add more operations to it. Relevant comment here:

#5741 (comment)

@realbigsean realbigsean added good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does! labels Jun 26, 2024
@sergerad
Copy link

@realbigsean could you please elaborate on your comment about per-operation metrics?

Are you suggesting a new metric within pub fn get_pending_balance_to_withdraw() ? A timer metric?

Thanks

@realbigsean
Copy link
Member Author

Sorry for the delayed response @sergerad !

We have this method process_operations. Within it, you can see a bunch of methods all prefixed process_*. So I was thinking we add timer metrics for each of these process_* methods. There was a performance concerned related to get_pending_balance_to_withdraw which lies in process_execution_layer_withdrawal_requests. So adding timer metrics for process_* methods would also give us an idea of whether that is actually problematic in practice.

@dapplion
Copy link
Collaborator

Another option is do add benches, as the time per op should be predictable given the block input. Then if we see that the overall block processing time metric spikes for block X, we can run the local benches against block X and optimize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does!
Projects
None yet
Development

No branches or pull requests

3 participants