Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-21829: Properly remove excluded lex refs #207

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

JakeOliver28
Copy link
Contributor

@JakeOliver28 JakeOliver28 commented Nov 14, 2024

This change is Reviewable

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) November 14, 2024 21:54
@jasonleenaylor
Copy link
Contributor

Src/xWorks/DictionaryPublicationDecorator.cs line 528 at r1 (raw file):

		/// <param name="hvoRef"></param>
		/// <returns></returns>
		public bool IsPublishableLexRef(int hvoRef)

If internal is enough I would use that.

@JakeOliver28
Copy link
Contributor Author

Src/xWorks/DictionaryPublicationDecorator.cs line 528 at r1 (raw file):

		/// <param name="hvoRef"></param>
		/// <returns></returns>
		public bool IsPublishableLexRef(int hvoRef)

If internal is enough I would use that.

Done

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JakeOliver28)

@JakeOliver28 JakeOliver28 merged commit 25a2a14 into release/9.1 Nov 15, 2024
4 of 5 checks passed
@JakeOliver28 JakeOliver28 deleted the LexicalRelationsPublication branch November 15, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants