Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lt 21934b: FLEx freezes when closing Try a Word if it is parsing #208

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Lt 21934b: FLEx freezes when closing Try a Word if it is parsing #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4703e8b
Fix LT-21934: FLEx freezes when closing Try a Word if parser is running
jtmaxwell3 Nov 15, 2024
c931a89
Remove redundant code
jtmaxwell3 Nov 15, 2024
6e46e6a
Merge branch 'release/9.1' into LT-21934b
JakeOliver28 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Src/LexText/ParserUI/ParserUIStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Src/LexText/ParserUI/ParserUIStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,4 +344,7 @@
<data name="ksEnterComment" xml:space="preserve">
<value>Please enter a comment for the parser report</value>
</data>
<data name="ksStoppingParser" xml:space="preserve">
<value>Stopping the Parser (may take up to a minute)</value>
</data>
</root>
1 change: 1 addition & 0 deletions Src/LexText/ParserUI/TryAWordDlg.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ protected override void OnClosed(EventArgs ea)
m_persistProvider.PersistWindowSettings(PersistProviderID, this);
if (m_parserListener.Connection != null)
{
this.Text = ParserUIStrings.ksStoppingParser;
m_parserListener.Connection.TryAWordDialogIsRunning = false;
m_parserListener.DisconnectFromParser();
}
Expand Down
2 changes: 0 additions & 2 deletions Src/XCore/xWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,8 +1929,6 @@ public bool OnCloseWindow(object sender)
{
CheckDisposed();

if (Mediator != null)
Mediator.SendMessage("StopParser", null);
this.Close();

return true;
Expand Down
Loading