Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor history tab CMSMain/HierarchyModelAdmin #2948

Open
GuySartorelli opened this issue May 30, 2024 · 2 comments
Open

Refactor history tab CMSMain/HierarchyModelAdmin #2948

GuySartorelli opened this issue May 30, 2024 · 2 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented May 30, 2024

Follow-up work from #2947

CMSMain has a history tab which only works for SiteTree. It should be made to work for any model which is versioned.

Benefits

  • allows the history tab functionality to be used for all versioned models

Related

Acceptance criteria

  • The history tab works for any model that has the Versioned extension applied
  • The history tab is not present for models that don't have the Versioned extension applied
  • The history tab can be used for multiple different models in the same project

TO BE DECIDED

  • Do we want the versioned tab to still be handled in its own controller?
    • If not, should it be added by the controller, or by silverstripe/versioned-admin for all versioned records?
@emteknetnz
Copy link
Member

It may make more sense to just get rid of the CMSMain history tab and instead get pages to use versioned-admin instead.

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Oct 1, 2024

That's likely what this refactor would result in, yeah. That doesn't mean removing the tab so much as using the HistoryViewerField directly in a tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants