Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilesystemPublisher will attempt to use rewrite_hash_links php which doesn't work #36

Open
ss23 opened this issue Apr 20, 2015 · 1 comment

Comments

@ss23
Copy link
Contributor

ss23 commented Apr 20, 2015

if($this->fileExtension == 'php') {
    Config::inst()->update('SSViewer', 'rewrite_hash_links', 'php');
}

This won't work because rewrite_hash_links works like:
$thisURLRelativeToBase = "<?php echo Convert::raw2att(\$_SERVER['REQUEST_URI']); >";

The static published PHP pages don't have a definition for Convert.

Simplest fix is to change Framework so that it's more like:
$thisURLRelativeToBase = "<?php echo htmlspecialchars(\$_SERVER['REQUEST_URI'], ENT_QUOTES); >";
but unsure if that's "best".

ss23 pushed a commit to ss23/silverstripe-staticpublishqueue that referenced this issue Apr 20, 2015
IgorNadj pushed a commit to ss23/silverstripe-staticpublishqueue that referenced this issue Feb 1, 2016
@edlinklater edlinklater added this to the 4.0 milestone Nov 1, 2016
@maxime-rainville
Copy link
Contributor

Need to validate if this still affects SS4.

@dhensby dhensby modified the milestones: 4.0, 5.0.1 May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants