From 58e03f8ab27de775a620a2c5c3c0bd3bec3a621d Mon Sep 17 00:00:00 2001 From: Sabina Talipova Date: Tue, 10 Oct 2023 14:46:19 +1300 Subject: [PATCH] MNT Remove TODO comments --- src/VersionFeed.php | 1 - tests/VersionFeedFunctionalTest.php | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/VersionFeed.php b/src/VersionFeed.php index ecac76b..ad7e1bc 100644 --- a/src/VersionFeed.php +++ b/src/VersionFeed.php @@ -203,7 +203,6 @@ public function updateSettingsFields(FieldList $fields) public function getSiteRSSLink() { - // TODO: This link should be from the homepage, not this page. if (Config::inst()->get(get_class(), 'allchanges_enabled') && SiteConfig::current_site_config()->AllChangesEnabled ) { diff --git a/tests/VersionFeedFunctionalTest.php b/tests/VersionFeedFunctionalTest.php index a1143d0..91521bc 100644 --- a/tests/VersionFeedFunctionalTest.php +++ b/tests/VersionFeedFunctionalTest.php @@ -175,7 +175,7 @@ public function testChangesActionContainsChangesForCurrentPageOnly() $titles = array_map(function ($item) { return (string)$item->title; }, $xml->xpath('//item') ?? []); - // TODO Unclear if this should contain the original version + $this->assertContains('Changed: Page1', $titles); $this->assertNotContains('Changed: Page2', $titles); @@ -184,7 +184,7 @@ public function testChangesActionContainsChangesForCurrentPageOnly() $titles = array_map(function ($item) { return (string)$item->title; }, $xml->xpath('//item') ?? []); - // TODO Unclear if this should contain the original version + $this->assertNotContains('Changed: Page1', $titles); $this->assertContains('Changed: Page2', $titles); }