Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure #18

Merged
merged 26 commits into from
Sep 24, 2024
Merged

Reconfigure #18

merged 26 commits into from
Sep 24, 2024

Conversation

jcapriot
Copy link
Member

This separates much of the pieces for the cython interface to pardiso and the python interface, slightly simplify the redundant code depending on the integer length.

I also spent a decent amount of time trying to debug the 2024 MKL testing issues on windows.
This is what I've found:

  • It seemed that the intel-openmp library conflicted with whatever library openblas used.
  • Forcing conda-forge to use the MKL for its blas library on windows seemed to be more consistent with what this is intended for. We will likely want to update the conda-forge recipe for windows to include the MKL blas requirement to avoid the runtime errors that I was seeing.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 60.37736% with 63 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (79c4103) to head (e017d0e).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pydiso/mkl_solver.py 58.27% 41 Missing and 22 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #18       +/-   ##
===========================================
+ Coverage   40.49%   73.80%   +33.30%     
===========================================
  Files           3        3               
  Lines         363      271       -92     
  Branches       18       58       +40     
===========================================
+ Hits          147      200       +53     
+ Misses        214       47      -167     
- Partials        2       24       +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit 6db5c02 into main Sep 24, 2024
34 checks passed
@jcapriot jcapriot deleted the ci_maintenance branch September 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant