-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link is not dead but errors have been found #50
Comments
Hi, it definitely looks related to #42. |
Getting the same for https://vimeo.com/163522126: |
Please report these false-positives to https://github.com/transitive-bullshit/check-links It's the package used to check the links. |
So I guess it would require to make https://github.com/transitive-bullshit/check-links/blob/3b08216d01a1107f0c692f611b11274f996006ca/lib/check-link.js#L38 customizable, and increase it in this module ? (cc @transitive-bullshit) |
I'll have some time to look into this soon. For now, I've opened an issue to track this. |
@HorlogeSkynet can you provide some additional false negatives in the above issue that you're seeing problems with? |
It's due to a bug in awesome-lint / check-links sindresorhus/awesome-lint#50
Similar false positive error found by @CompSciLauren in sindresorhus/awesome#1595 (comment) Oddly, when I ran (base) wm962-fdf:awesome-cytodata gway$ awesome-lint
⠙ Linting(node:6962) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
✖ Linting
readme.md:1:1
✖ 1:1 The repository should have "awesome" as a GitHub topic remark-lint:awesome/github
✖ 1:1 The repository should have "awesome-list" as a GitHub topic remark-lint:awesome/github
2 errors (These are also false postives, probably b/c I am running awesome-lint on my fork) |
There is definitely a broader issue here with the remark-lint:no-dead-urls rule. See my proposal in #89 to work around it. |
awesome-lint finds errors following 2 cases which is not dead
i) Link to https://arxiv.org/abs/* is dead
ii) Link to https://arxiv.org/pdf/* is dead
For example, Link to https://arxiv.org/pdf/1611.01603.pdf is dead
The text was updated successfully, but these errors were encountered: