How ky handle errors like 'ETIMEDOUT', 'ECONNRESET', 'ECONNREFUSED', 'ENOTFOUND'...

[joolfe]

So I'm trying to reproduce an error like 'ETIMEDOUT', 'ECONNRESET', 'ECONNREFUSED', 'ENOTFOUND'... using nock and in got I remember to do something like

    const scope = nock('https://example.com')
        .get('/test')
        .replyWithError({code: 'ECONNRESET'});

But doing the same with ky I'm not able to handle correctly in the catch block as the HTTPError has something like:

HTTPError: Request failed with an unknown error: GET https://engine.suks1ew2accsinnovgene002.sandbox.tlzproject.com/as/authorization.oauth2?client_id=load_test_client&response_type=code&redirect_uri=https%3A%2F%2Flocalhost%3A4200%2Fcallback&response_mode=form_post&scope=openid+profile&nonce=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&state=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&code_challenge=EiABe5V_ZURpIQOVLkQxWmBJVR-3koj66lSxaRAEZCw&code_challenge_method=S256
    at function_ (file:///Users/jorge/Projects/vite-project-js/node_modules/ky/source/core/Ky.ts:57:17)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Ky._retry (file:///Users/jorge/Projects/vite-project-js/node_modules/ky/source/core/Ky.ts:259:11)
    at OAuthClient.authorizeWithResponseModePost (/Users/jorge/Projects/vite-project-js/src/main/oauth/oauth-client.js:113:14)
    at /Users/jorge/Projects/vite-project-js/src/test/oauth-client.test.js:224:7
    at runTest (file:///Users/jorge/Projects/vite-project-js/node_modules/@vitest/runner/dist/index.js:955:11)
    at runSuite (file:///Users/jorge/Projects/vite-project-js/node_modules/@vitest/runner/dist/index.js:1111:15)
    at runSuite (file:///Users/jorge/Projects/vite-project-js/node_modules/@vitest/runner/dist/index.js:1111:15)
    at runFiles (file:///Users/jorge/Projects/vite-project-js/node_modules/@vitest/runner/dist/index.js:1168:5)
    at startTests (file:///Users/jorge/Projects/vite-project-js/node_modules/@vitest/runner/dist/index.js:1177:3) {
  response: {
    code: 'ECONNRESET',
    url: 'https://engine.suks1ew2accsinnovgene002.sandbox.tlzproject.com/as/authorization.oauth2?client_id=load_test_client&response_type=code&redirect_uri=https%3A%2F%2Flocalhost%3A4200%2Fcallback&response_mode=form_post&scope=openid+profile&nonce=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&state=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&code_challenge=EiABe5V_ZURpIQOVLkQxWmBJVR-3koj66lSxaRAEZCw&code_challenge_method=S256'
  },
  request: Request {
    bodyUsed: false,
    method: 'GET',
    body: null,
    credentials: 'same-origin',
    headers: Headers { [Symbol(entries)]: {} },
    redirect: 'follow',
    referrerPolicy: '',
    signal: AbortSignal {
      aborted: false,
      reason: null,
      onabort: null,
      [Symbol(listeners)]: [Object],
      [Symbol(listenerOptions)]: [Object]
    },
    [Symbol(contentLength)]: null,
    [Symbol(contentType)]: null,
    [Symbol(referrer)]: 'client',
    [Symbol(bodyBuffer)]: null,
    [Symbol(url)]: URL {
      href: 'https://engine.suks1ew2accsinnovgene002.sandbox.tlzproject.com/as/authorization.oauth2?client_id=load_test_client&response_type=code&redirect_uri=https%3A%2F%2Flocalhost%3A4200%2Fcallback&response_mode=form_post&scope=openid+profile&nonce=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&state=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&code_challenge=EiABe5V_ZURpIQOVLkQxWmBJVR-3koj66lSxaRAEZCw&code_challenge_method=S256',
      origin: 'https://engine.suks1ew2accsinnovgene002.sandbox.tlzproject.com',
      protocol: 'https:',
      username: '',
      password: '',
      host: 'engine.suks1ew2accsinnovgene002.sandbox.tlzproject.com',
      hostname: 'engine.suks1ew2accsinnovgene002.sandbox.tlzproject.com',
      port: '',
      pathname: '/as/authorization.oauth2',
      search: '?client_id=load_test_client&response_type=code&redirect_uri=https%3A%2F%2Flocalhost%3A4200%2Fcallback&response_mode=form_post&scope=openid+profile&nonce=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&state=nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o&code_challenge=EiABe5V_ZURpIQOVLkQxWmBJVR-3koj66lSxaRAEZCw&code_challenge_method=S256',
      searchParams: URLSearchParams {
        'client_id' => 'load_test_client',
        'response_type' => 'code',
        'redirect_uri' => 'https://localhost:4200/callback',
        'response_mode' => 'form_post',
        'scope' => 'openid profile',
        'nonce' => 'nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o',
        'state' => 'nRKE5HUOapLfSivNtjNrdOotsc_PsZFA8HxRve_Ph2o',
        'code_challenge' => 'EiABe5V_ZURpIQOVLkQxWmBJVR-3koj66lSxaRAEZCw',
        'code_challenge_method' => 'S256' },
      hash: ''
    }
  },
  options: {
    method: 'GET',
    headers: [],
    hooks: {
      beforeRequest: [],
      beforeRetry: [],
      beforeError: [],
      afterResponse: []
    },
    prefixUrl: '',
    retry: {
      limit: 2,
      methods: [Array],
      statusCodes: [Array],
      afterStatusCodes: [Array],
      maxRetryAfter: Infinity,
      backoffLimit: Infinity,
      delay: [Function: delay]
    },
    throwHttpErrors: true,
    timeout: 10000,
    fetch: [Function: bound ] AsyncFunction,
    signal: AbortSignal {
      aborted: false,
      reason: null,
      onabort: null,
      [Symbol(listeners)]: [Object],
      [Symbol(listenerOptions)]: [Object]
    }
  }
}

Is this the way to handle this type of errors in ky? using the error.response.code?

Best regards

[outaTiME]

I’m in the same boat.

I’m using this library in AWS Lambdas, and I would like to be able to retry this type of errors, just like GOT handles it (https://github.com/sindresorhus/got/blob/main/documentation/7-retry.md).

I believe KY should follow the same logic.

By the way, @joolfe, were you able to solve this issue in some way? The documentation doesn’t seem to allow this clearly. Also, @sindresorhus or @szmarczak, do you have any insights or suggestions on this?

[sholladay]

Ky should be retrying these errors automatically already. Do you have evidence to the contrary? A code example that we can reproduce?

[outaTiME]

In my case, Ky is not retrying these errors automatically. Instead, an exception is being thrown. I also looked through Ky’s code and couldn’t find any references to retrying this specific type of errors, which is something GOT does handle.

[outaTiME]

Additionally, in the following method: https://github.com/sindresorhus/ky/blob/main/source/core/Ky.ts#L208, there is no reference to handling error codes, unlike in GOT’s method: https://github.com/sindresorhus/got/blob/main/source/core/calculate-retry-delay.ts#L21

[sholladay]

I'm not sure why you are expecting to find references to every single possible error case. There's nothing particularly special about these.

Look at the last line of the function from your second link, as you can see we retry all errors by default unless there's a reason not to. These errors have not been excluded from that behavior, therefore there's no need to reference them.

If Ky is indeed not retrying them, then that sounds like a bug, something I could perhaps investigate if you share some reproducible code.