-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intervalCap not respected when using large intervalCaps or small intervals #126
Comments
// @Rafael09ED |
Interesting. Just adding that 1 test causes failures in multiple other tests.
After:
in tests
Since the tests, to my understanding, run in parallel perhaps they are interfering with each other. I don't know how this is possible but I have some far fetched guesses if someone has any ideas. I will have to look into this more after work. |
@thejamespower, I think I shortened the From the log I don't see any unexpected behavior based on the timestamps. Every Log w/ timestamps
|
Thanks for investigating @Rafael09ED. Yes, I noticed adding this test result in other tests breaking, unfortunately, I have no experience in your chosen test runner to be able to investigate any further. I would love to be able to spend some time on this, unfortunately, we do not have the spare capacity right now, so will have to find another library/solution. |
@thejamespower Did you find a workable solution? I have run into this as well. With rate limits 50 per second, max 10 concurrency requests, this configuration breaches the limits very quickly. It even happens if I add some padding.
|
Experiencing the same issue |
We have been trying to debug an issue with our PQueue in our application for a few weeks now. We keep getting throttled by our API provider for going over their 2000/minute request limit. Even with setting our
intervalCap
to 1900/minute, we were still breaching the limit regularly.I modified one of the current tests to prove that somethings starts to go wrong when you increase the
intervalCap
to numbers above 1. The current tests files use a cap of one which always passes. When you increase theintervalCap
to above ~100, the test starts failing randomly. Sometimes it passes, sometimes it fails. The higher theintervalCap
, the more likely it is to fail.It's worth noting the same behaviour is demonstrated if you use small
intervals
(<100).The text was updated successfully, but these errors were encountered: