Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving image file should say where it has been saved on desktop #1759

Closed
1 task done
Muhammed-Rahif opened this issue Feb 28, 2024 · 5 comments · Fixed by #2403
Closed
1 task done

Saving image file should say where it has been saved on desktop #1759

Muhammed-Rahif opened this issue Feb 28, 2024 · 5 comments · Fixed by #2403
Labels
desktop Issues or feature requests related to desktop platforms (e.g., Windows, macOS, Linux). enhancement New feature or request

Comments

@Muhammed-Rahif
Copy link
Contributor

Muhammed-Rahif commented Feb 28, 2024

Is there an existing issue for this?

Follow:

  1. Add image
  2. Click on the added image, image menu popup will appear
  3. From the image menu click on save
  4. A result snackbar will appear

On the result snackbar it should say where the image file has been saved, otherwise on different platforms it hard to find where it. The result snackbar should say something like: "The image has been saved at: path/to/location"

The current message is "Saved using the network".

I was using flutter quill on linux, after saving the image file I have searched it on all folders to find it. After some effort I found it was gal or gal_linux is saving it on `/tmp/gal/image.png'.

@Muhammed-Rahif Muhammed-Rahif added the enhancement New feature or request label Feb 28, 2024
@EchoEllet
Copy link
Collaborator

I might do this for desktop but for mobile it's not a good idea as the app is sandboxed and the path will be useless

@Muhammed-Rahif
Copy link
Contributor Author

I see this has implemented on

message = localizations.theImageHasBeenSavedAt(imageSource);

@EchoEllet
Copy link
Collaborator

EchoEllet commented Dec 2, 2024

I see this has implemented on
message = localizations.theImageHasBeenSavedAt(imageSource);

The behavior is broken and the issue was not fixed correctly, it always shows the imageSource which can be an HTTP image URL or image file path. This functionality has been rewritten in #2403 (with manual and automated tests).

@Muhammed-Rahif
Copy link
Contributor Author

I might do this for desktop but for mobile it's not a good idea as the app is sandboxed and the path will be useless

Does this work on mobile devices now or only for desktop as previously said?

@EchoEllet EchoEllet changed the title Saving image file should say where it has been saved Saving image file should say where it has been saved on desktop Dec 2, 2024
@EchoEllet EchoEllet added the desktop Issues or feature requests related to desktop platforms (e.g., Windows, macOS, Linux). label Dec 2, 2024
@EchoEllet
Copy link
Collaborator

Does this work on mobile devices now or only for desktop as previously said?

Previously for mobile, desktop support was broken or confusing, and the web was not supported.

It works on all platforms now (not merged or published yet), including the web. The message is slightly different based on the platform, and no longer shows Saved using the network (messages have been improved).

As for the image file path (where it has been saved), currently, it shows the Snackbar message with an action (labeled Open File Location) that opens the file in the system file explorer. I do plan on making some changes before publishing:

  • Whether it should show the image file path in the message itself; it's no longer useful, the button can open it within the system file explorer.
  • Whether the action should open the directory of that saved file or the file itself, this can be slightly different based on the platform.

The Snackbar message:

  • Desktop: Image saved successfully. with action labeled Open File Location.
  • Web: Image downloaded successfully. with no action; it's not needed.
  • Gallery image save (supports mobile platforms + macOS): Image saved to your gallery. with action labeled Open Gallery.

Refer to #2403 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Issues or feature requests related to desktop platforms (e.g., Windows, macOS, Linux). enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants