Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used curve is incorrect #8

Open
dynamix opened this issue Jul 31, 2020 · 5 comments
Open

Used curve is incorrect #8

dynamix opened this issue Jul 31, 2020 · 5 comments

Comments

@dynamix
Copy link

dynamix commented Jul 31, 2020

The example uses p256 but Apple requires p192.

@egorlitvinenko
Copy link

Confirmed
https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network

However, it looks like they changed the docs.

@dynamix
Copy link
Author

dynamix commented Jul 31, 2020

They did, which is annoying because the key we submitted in the beginning used secp256r1. The choice of prime192v1 is questionable and I wrote them about it (nobody uses it, not all libs support it, it is considered not very secure, more hash digest than bits in the curve ...)

@danielxt7
Copy link
Contributor

thanks @dynamix - yep, we also suspect this changed... we are updating the repo to use prime192v1 - thx!

@bzarzoza
Copy link

that guidance has changed once again to prime256v1

old: http://web.archive.org/web/20200920102544if_/https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network
new: https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network

@fmaschmeier
Copy link
Contributor

change to p192 plus a note in readme to highlight necessary equality in keypair and adserver -> addressed with #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants