Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with tooltip positioning #398

Open
tempo22 opened this issue May 20, 2020 · 4 comments
Open

Issue with tooltip positioning #398

tempo22 opened this issue May 20, 2020 · 4 comments

Comments

@tempo22
Copy link

tempo22 commented May 20, 2020

Hi,

I'm currently running into the same issue as this one: #381

In the process of upgrading an addon to octane, I'm using ember-tooltips v3.4.3 with ember 3.18.0.

Using the following code

    <LpButton @variant="neutral">
      Tooltip
      <EmberTooltip @text="Here is more info!" />
    </LpButton>

This is the positioning of the first render:
image

and here is the positioning of the following renders:
image

Do you know what I'm missing to have this bug resolved like in the linked issue?

@maxfierke
Copy link
Collaborator

@tempo22 could you verify whether there are any other addons depending on ember-tooltips that may be pulling in an old version?

@tempo22
Copy link
Author

tempo22 commented May 20, 2020

This is my yarn.lock file:

ember-tooltips@~3.4.3:
  version "3.4.3"
  resolved "https://registry.yarnpkg.com/ember-tooltips/-/ember-tooltips-3.4.3.tgz#a017de33e53a9b9ca6d38b8c2f829cc3024b8f8b"
  integrity sha512-/swhfhodVvpKi6R+tkcqLgS0YTMo3S6Mzb8qtfTneFSz+tBhY/kd/+eI8OIZf9qocpJ9b54dbbqTw5ZBkeZe2g==
  dependencies:
    broccoli-file-creator "^2.1.1"
    broccoli-funnel "^2.0.2"
    broccoli-merge-trees "^2.0.0"
    broccoli-source "^2.0.0"
    broccoli-string-replace "^0.1.2"
    ember-cli-babel "^7.13.0"
    ember-cli-htmlbars "^4.2.0"
    ember-maybe-in-element "^0.4.0"
    popper.js "^1.12.5"
    resolve "^1.10.1"
    tooltip.js "^1.1.5"

@maxfierke
Copy link
Collaborator

@tempo22 would you be able to provide more information about how LpButton is composed? e.g. the DOM structure of it and any CSS styling it or the container its in

@tempo22
Copy link
Author

tempo22 commented May 21, 2020

@maxfierke I'm digging a bit this issue. I made a simpler demo and still had the bug even with simple divs.

I could notice the bug wasn't happening in some pages and the only difference is an unrelated JS notice (I'm using ember-cli-addon-docs):

Uncaught (in promise) Error: Assertion Failed: DocsRoutes wasn't able to correctly detect the current route.

I'll check if I can get rid of that error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants