Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to popper@2? #399

Open
andreyfel opened this issue May 22, 2020 · 8 comments
Open

Upgrade to popper@2? #399

andreyfel opened this issue May 22, 2020 · 8 comments
Labels

Comments

@andreyfel
Copy link

It seems popper bumped major version. Is there a plan to migrate?

ember-tooltips > tooltip.js@1.3.3: Tooltip.js is not supported anymore, please migrate to tippy.js
ember-tooltips > popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
ember-tooltips > tooltip.js > popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
@maxfierke
Copy link
Collaborator

There's a rough idea in my head to do it for a v4 release at some in the near future, but have not started working on it.

@gorner
Copy link

gorner commented Feb 7, 2023

@maxfierke Are there still any plans for updating to popper.js v2, or for that matter its replacement floating-ui? I'm working on updating an app that currently uses ember-attacher, but with that having been neglected for some time, I'm trying to get a sense of the future of this project compared to newer solutions like ember-tippy, ember-popper-modifier or ember-velcro.

@maxfierke
Copy link
Collaborator

@gorner I started spiking on a v4 that refactored everything into Glimmer components w/ popper@2 & tippy-based modifiers. I'll have to find that branch again, but I think there was still a bit more work to go. The fact that popper.js v2 is already being replaced with something else kind of irks me, but I guess it's been three years already (pandemic time brain!)

I haven't been doing much Ember stuff (or JavaScript in general) for the past nine months or so, so there's a slim chance that I get back to working on this myself, but happy to help enable anyone else to provide a good path forward!

If I was starting something new, I'd probably try something modifier-based. ember-velcro looks kind of interesting. Would be curious if one could wrap it in an ember-tooltips-compatible component API.

@gorner
Copy link

gorner commented Feb 7, 2023

@maxfierke Thanks for the reply, completely understandable. I agree some sort of compatible wrapper using ember-velcro and/or whatever replaces Tippy.js would be the best long-term solution, but we might go with ember-tippy for the time being. It's always ideal when the Ember community can coalesce around a common solution – the whole "stability without stagnation" thing – but that community is definitely smaller these days.

cc @jelhan and @NullVoxPopuli who I noticed recently having a discussion on a related matter.

@pzubar
Copy link

pzubar commented Feb 8, 2023

@gorner what a coincidence, I've recently opened the draft PR with a proposal to update "ember-popper-modifier" to Floating UI. The PR contains a fully-working version of the addon, but with Floating UI instead of Popper. Still, this will barely become a part of that addon (see details in conversation, it is still pending).

I would be glad to contribute to such an upgrade/migration to the ember-tooltip library and hear your thoughts on what is needed for that. I agree that ember-velcro looks interesting. Maybe using it under the hood of the new version of ember-tooltips makes sense? Does it make sense to focus on updating/integrating it into this library?

P.S. I am working on an update an app that currently uses ember-attacher as well, and I think that the best long-term solution is to use the Floating UI-based solution.

@pzubar
Copy link

pzubar commented May 15, 2023

For those who are interested in the floating-ui ember solution, it is now supported by ember-attacher (starting from v2).

@NullVoxPopuli
Copy link

Why's it depend on sass?

@pzubar
Copy link

pzubar commented May 16, 2023

Historically, it is used there for the show/hide transition animations and, partially, for the arrow positioning. TBH, I think about dropping sass in the future in some way.

Or, maybe it is possible to use sass internally only and don't make it a dependency, but, unfortunately, I don't yet know the way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants