Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Appropriateness of having the index tab – Study Bible import #3881

Closed
3 tasks done
ux-git opened this issue Jan 2, 2025 · 3 comments
Closed
3 tasks done

[Bug] Appropriateness of having the index tab – Study Bible import #3881

ux-git opened this issue Jan 2, 2025 · 3 comments
Assignees
Labels
bug Something isn't working implemented Taken care of by a new commit/version

Comments

@ux-git
Copy link
Contributor

ux-git commented Jan 2, 2025

What happened?

Does it make sense to have the "INDEX" tab while there's no content to fetch from it, and this tab is inactive for everyone all the time?

To Reproduce

  1. Go to Import Study Bible
  2. Try to click the INDEX tab

What did you expect to happen?

I thought there's an error fetching, but turned out there's just no content. Maybe it would make sense to get rid of this tab?

Version

24.12.2

What platform are you seeing the problem on?

macOS

Relevant log output

No response

Screenshots

No response

Additional context

No response

Confirmations

  • I confirm that I have read the documentation website.
  • I confirm that I have searched through the existing issues to make sure my bug report is not a duplicate.
  • I confirm that I have searched through the existing discussions to make sure my bug report is not a duplicate.
@ux-git ux-git added the bug Something isn't working label Jan 2, 2025
@ux-git ux-git changed the title [Bug] Appropriateness of using the index – Study Bible import [Bug] Appropriateness of having the index tab – Study Bible import Jan 2, 2025
@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Jan 9, 2025

We don't have an exact way of identifying the INDEX tab. We could hide all tabs that have no media though, instead of disabling them.

@ux-git
Copy link
Contributor Author

ux-git commented Jan 9, 2025

Yes, hiding is exactly what I meant

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Jan 9, 2025

Done in 5a7a7a4

@mtdvlpr mtdvlpr added the awaiting-release Will be released with next update label Jan 9, 2025
@mtdvlpr mtdvlpr added implemented Taken care of by a new commit/version and removed awaiting-release Will be released with next update labels Jan 17, 2025
@mtdvlpr mtdvlpr closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working implemented Taken care of by a new commit/version
Projects
None yet
Development

No branches or pull requests

3 participants