Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set height attribute on img-tag when using lazy loading #105

Open
sir-gawain opened this issue Jun 13, 2023 · 0 comments
Open

Set height attribute on img-tag when using lazy loading #105

sir-gawain opened this issue Jun 13, 2023 · 0 comments

Comments

@sir-gawain
Copy link

sir-gawain commented Jun 13, 2023

If i use <picture> tag with sources with "srcset" and "sizes", and enable lazy loading using the native loading="lazy" attribute, Chrome does not load the images on page load. Adding the height attribute to the image-tag solves the problem.

Add in line 239 of ResponsiveImagesUtility.php:
$fallbackTag->addAttribute('height', $fallbackImage->getProperty('height'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant