Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cropping suffixes #6

Open
s2b opened this issue Sep 12, 2017 · 3 comments
Open

Support cropping suffixes #6

s2b opened this issue Sep 12, 2017 · 3 comments
Assignees

Comments

@s2b
Copy link
Collaborator

s2b commented Sep 12, 2017

Currently, the ImageViewHelper only partially supports the c and m suffixes for manually specified height and width.

One possible solution could be to convert the specified values to a crop area object.

@DanielRuf
Copy link

DanielRuf commented Sep 19, 2017

Currently, the ImageViewHelper only partially supports the c and m suffixes for manually specified height and width.

This is not quite clear to me. So we can we use a value like 800c instead of 800 or does this not work with your viewhelper (sms namespace)?

@s2b
Copy link
Collaborator Author

s2b commented Sep 19, 2017

Currently, the specified width will be applied to the fallback image only, the height will be skipped completely. So no, it is not safe to use those parameters with my ViewHelpers.

The problem is that supporting these values would lead to a bunch of complicated edge cases which I wasn't able to solve yet.

@s2b s2b self-assigned this Sep 19, 2017
@s2b s2b added the bug label Feb 4, 2018
@s2b s2b modified the milestone: ponyhof Feb 4, 2018
@s2b s2b added the backlog label Feb 4, 2018
@s2b s2b added next and removed backlog labels Mar 15, 2018
@NiklasLazinbee
Copy link

I think it fits in with this issue: the height specifications are apparently not supported. Normally I can write in fluid:
<f:image src="{image.originalResource.publicUrl}" width="314" maxHeight="400"/>

If I have a portrait format, the image will be rendered up to a maximum of 400.
This could be a helpful feature.

@s2b s2b added backlog and removed next labels Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants