Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate UI to French #8

Open
skatrak opened this issue Sep 22, 2014 · 8 comments
Open

Translate UI to French #8

skatrak opened this issue Sep 22, 2014 · 8 comments

Comments

@skatrak
Copy link
Owner

skatrak commented Sep 22, 2014

The file where the translation must be done is mcserveradmin.fr.ts

@AL3XEY
Copy link
Contributor

AL3XEY commented Oct 11, 2014

Hi, I can start working on it since I am French. Thank you for linking the file location.

Edit : Half of the strings are translated. I would like to see my work on the actual program, but I got errors when compiling it in Qt Creator. Any advice to get it working? Is there something to set up?

@skatrak
Copy link
Owner Author

skatrak commented Oct 18, 2014

Hello! Sure, you can translate the UI to French.

If you tell me the platform (OS, Qt version and compiler) you are using and the error log you are getting when compiling (you can use pastebin.com for that and link here) maybe I can check it out and help you with that.

In any case, be sure that you have a Qt version >= 5.2.1 and a C++11 compatible compiler. If it's not that, probably the problem is me using compiler-specific stuff, so the compiler error log would have all the information I need to make it work.

And thank you very much for the help. I really appreciate it!

@AL3XEY
Copy link
Contributor

AL3XEY commented Oct 19, 2014

I am using Ubuntu 14.04, Qt Creator 3.2.1 (Qt 5.3.2 - GCC 4.6.1 64 bit).
I also tried on Windows 7 Familial Premium (compiler : MSVC 2010 32 bits), just in case. But I got the same 10 errors (and a lot of warnings, but whatever, errors are more important at the moment).

I saw C++98 on the error messages, so I searched on the Internet and I found something about adding a line in the .pro file to switch to C++11. Then I got 38 errors.

The line I added is :

QMAKE_CXXFLAGS += -std=c++11

I tried to replace this line by some others with the same purpose, but I don't remember which ones.

Also, you say you are "using compiler-specific stuff", well I don't know if I'm saying something dumb, but why don't you write a Makefile to be sure it all compiles as you want?

P.S.: It is always a pleasure to help!

@skatrak
Copy link
Owner Author

skatrak commented Oct 19, 2014

Thank you very much for your help, I'm going to check your compiler error logs to see what I messed up. It seems to me that it has something to do with the enums declarations in the code, so hopefully it won't be a big pain to fix.

With the "compiler -specific stuff" I meant that maybe I used at some point some extensions of the language that my compiler (MSVC 2013) has and that are non-standard. If I did that, then the code would not compile in any other compiler or even older versions of itself (which seems that it's the problem in this case). I don't want that to happen, but because I hadn't tried compiling with any other compilers, I guess that some non-standard compliant code slipped through.

The problem is not to be solved with some #defines or compiler flags (except from -std=c++11), but changing some syntax so that it works everywhere, so I don't think a Makefile would help there. Thank you for the ideas, though.

@AL3XEY
Copy link
Contributor

AL3XEY commented Oct 20, 2014

Okay, I see. Well, I'm glad to be helpful!

I will push the first version of the translated strings soon on my repo, but I'll wait to be able to see the result on the UI to be sure the sentences aren't out of context.

Or if I got some time, I'll try to get MSVC 2013.

@skatrak
Copy link
Owner Author

skatrak commented Oct 21, 2014

I've just tried a solution, try it out when you can and tell me whether that solved the problem or not. Cheers.

@AL3XEY
Copy link
Contributor

AL3XEY commented Oct 21, 2014

Work is almost done. All the strings listed in the .ts file are translated, but I saw some more in need of a translation. I think I saw their locations in the code, so I'll try to fix it.

Edit : These are part of the C++ code and not the UI XML code, so I don't know how to do it.

See picture below.

transerrors

@skatrak
Copy link
Owner Author

skatrak commented Oct 22, 2014

Thank you for pointing that out, I overlooked it. For the panels with the "Name, Permission level, ..." I'm going to commit a fix now. For the Dialogs that pop up (Yes, No, Cancel, ...) I'm working on it right now, but it will take a little longer.

The state "Saved/Modified/Active..." is like the combo boxes for the "World Type" and all of that. For the moment they will stay like this until I find a solution, maybe I should open an issue for that.

skatrak added a commit that referenced this issue Oct 22, 2014
Add French translation for issue #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants