Joining the same VoiceChannel with different clients

[Majoramari]

If you have 2 clients, fetched voice channel in client one and try to join it in client two, client one will join. <Player>.voices.join(voiceChannel) this is the result of using the channel object here: (commit)... Potential fix is to fetch the channel again internally or just accept channel id as an argument.

Further information:

• DisTube version: 3.3.3
• discord.js version: 13.3.1
• Node.js version: 17.7.0
• Operating system: Windows 11/Debian 11

[skick1234]

this could lead to a lot of bugs because you always could pass a channel have a wrong client and you don't even know it...

Hmmm... I think people should handle the voice channel before joining it (reply interaction if it's full,...). Ofc I can make commit like your request and you can use try catch but the error is pre-determined and I don't recommended to do it. And DisTube still has to fetch the correct channel to check its permission before joining.

I will convert this to a discussion since the bug is "my feature" 🤣

[Majoramari]

Okay this is now a discussion, My suggestion is just make voice.join() accept channel id...

[skick1234]

I think people should handle the voice channel before joining it (reply interaction if it's full,...). Ofc ... you can use try catch but the error is pre-determined and I don't recommended to do it

You can simply create a method to join it.

Example:

client.joinVoiceId = async function(id){
   const voice = await this.channels.fetch(id)
   return this.distube.join(voice)
}

And reply interaction if it is not joinable

client.joinVoiceId = async function(interaction, id){
   const voice = await this.channels.fetch(id)
   if (!voice.joinable) return interaction.reply({...})
   return this.distube.join(voice)
}

[skick1234]

If I implement your suggestion, you have to write

try {
    await distube.voices.join(id)
} catch(e) {
    if (e.code === "...") interaction.reply({...})
    else ...
}

Ofc this is shorter but I don't want to do that :>

[skick1234]

Resolved with 32c362f