Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 0-welcome.yml doesn't run #44

Closed
Maxim-Mazurok opened this issue Jun 18, 2024 · 4 comments · Fixed by #46
Closed

[Bug] 0-welcome.yml doesn't run #44

Maxim-Mazurok opened this issue Jun 18, 2024 · 4 comments · Fixed by #46
Assignees
@hectorsector
Labels
bug Something isn't working needs engineering Requires engineering-specific changes only.

Comments

@Maxim-Mazurok
Copy link

0-welcome.yml workflow didn't run on repo creation, had to run it manually
@Maxim-Mazurok Maxim-Mazurok added the bug Something isn't working label Jun 18, 2024
@hectorsector
Copy link
Contributor

Thanks for the report, @Maxim-Mazurok. Duplicate of #37.

@hectorsector hectorsector closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
@Maxim-Mazurok
Copy link
Author

@hectorsector I wasn't sure if it is a duplicate, because the first workflow is triggered on repo creation. The other issue is about not triggering on PR I believe.

@sinsukehlab
Copy link
Contributor

I agree with @Maxim-Mazurok. This issue is about the Step 0 workflow, and #37 is about the Step 1 workflow.
I think this issue is related to skills/code-with-codespaces#87 and skills/copilot-codespaces-vscode#136.

@hectorsector
Copy link
Contributor

Apologies! Thanks for catching that @Maxim-Mazurok @sinsukehlab

@hectorsector hectorsector reopened this Jul 2, 2024
@hectorsector hectorsector added the needs engineering Requires engineering-specific changes only. label Jul 2, 2024
@hectorsector hectorsector self-assigned this Jul 2, 2024
@hectorsector hectorsector mentioned this issue Jul 2, 2024
Merged
2 tasks
@heiskr heiskr closed this as completed in #46 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorsector hectorsector

Labels
bug Something isn't working needs engineering Requires engineering-specific changes only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change trigger for step 0 to push skills/write-javascript-actions
3 participants
@Maxim-Mazurok @hectorsector @sinsukehlab