-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equality tests for dumpreader and SingleSpeciesAnalyzer #28
Comments
Equality tests for dumpreader have been implemented 341cdae. Its not straigt forward what |
Regarding #117 it may be useful to define "dr1 == dr2" to be True if they are returning the same particles in the same order (although from a possibly different dump)? |
If it becomes necessary to implement equality tests for singlespecies or multispecies objects, we can still do it. There is no obvious way here and also no obvious benefit. Closing the issue. |
Implement Equality tests for dumpreader and SingleSpeciesAnalyzer. This allows that ParticleAnalyzer can be added together without adding Particles twice, in case they overlap. It will also allow to easily check if a particle analyzer contains particles of another.
The text was updated successfully, but these errors were encountered: