Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Controller (Step 5) #332

Open
11 tasks
grahamia opened this issue Jul 4, 2024 · 0 comments · May be fixed by #408
Open
11 tasks

Provider Controller (Step 5) #332

grahamia opened this issue Jul 4, 2024 · 0 comments · May be fixed by #408
Assignees
Labels
enhancement New feature or request unrefined

Comments

@grahamia
Copy link
Contributor

grahamia commented Jul 4, 2024

Overview

Now that we have simplified the components down which are involved in the feedback loop of run completion we can implement the controller within the KFP-Operator which will reconcile on the provider custom resources, i.e. #329. The beauty of being down to one component in the provider layer is that we have no need for managing resources together, i.e. we have no need for helm therefore the controller can apply the resource directly. The deployment should be marked as a sub resource of the provider resource, and handle create/update/delete/out-of-sync events.

Technical Details

  • implement new controller, event processor deployment managed by controller
  • on implementing the controller the permissions should be added to the roles.yaml permissions so the temporary manager-providers-viewer-rolebinding cluster role binding can be removed
  • remove provider helm chart
  • update the documentation
  • status updates to the provider resource will have to be added at this point

Current Architecture

image

After Architecture

image

Acceptance Criteria

  • on applying a new provider custom resource, the provider service deployment resource is created
  • on updating the existing provider custom resource, then the provider service deployment is updated
  • on deleting the provider customer resource, then the provider service deployment is removed
  • when the provider service deployment is updated by something other than the provider controller, re-sync the deployment to match the provider resource
  • when the provider service deployment is deleted, a new provider service deployment is created
  • the provider service deployment must have a unique name (similar to how Deployments create pods with unique names)
@grahamia grahamia added enhancement New feature or request unrefined labels Jul 4, 2024
@grahamia grahamia added this to the Provider Custom Resource milestone Jul 4, 2024
@grahamia grahamia changed the title Provider Controller Provider Operator Jul 22, 2024
@grahamia grahamia changed the title Provider Operator Provider Controller Jul 24, 2024
@grahamia grahamia changed the title Provider Controller Provider Controller (Step 4) Aug 30, 2024
@grahamia grahamia changed the title Provider Controller (Step 4) Provider Controller (Step 5) Aug 30, 2024
@alexgeorgousis alexgeorgousis linked a pull request Dec 5, 2024 that will close this issue
9 tasks
@alexgeorgousis alexgeorgousis removed their assignment Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unrefined
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants