Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Dependenices pin Colorama to a lower version #3701

Open
hemildesai opened this issue Jun 27, 2024 · 1 comment
Open

AWS Dependenices pin Colorama to a lower version #3701

hemildesai opened this issue Jun 27, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@hemildesai
Copy link
Contributor

AWS Dependencies pin colorama to < 0.4.5 here. Is there a particular reason to do so?

AWS CLI has updated the colorama requirements here

Is it possible to update this? This requirements prevents lockfiles to be created when skypilot is used with other dependencies that depend on newer colorama versions.

I'm happy to contribute a PR for this, but unsure what tests to run.

@Michaelvll
Copy link
Collaborator

We pinned the colorama version just for AWS CLI dependencies, if AWS has published a new pypi release of AWS CLI with the new requirements, it should be good to upgrade our dependencies as well.

Please help submit a PR for this by increasing the version number for both aws cli and colorama. In our setup.py, we can use the lowest possible aws-cli version that has updated colorama to make sure the best compatibility. : )

@Michaelvll Michaelvll added the good first issue Good for newcomers label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants