Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to create a rotation #27

Open
filmaj opened this issue Sep 21, 2023 · 1 comment
Open

Fails to create a rotation #27

filmaj opened this issue Sep 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@filmaj
Copy link
Member

filmaj commented Sep 21, 2023

Here are the logs when running with slack run:

2023-09-21 12:43:37 [info] [Wf05SYNCFQSK] (Trace=Tr05TAAZCNG5) Workflow step 'Opens a rotation form' completed
2023-09-21 12:43:38 [info] [Wf05SYNCFQSK] (Trace=Tr05TAAZCNG5) Workflow step 3 of 4 started
2023-09-21 12:43:38 [info] [Fn05TD5T5LH1] (Trace=Tr05TAAZCNG5) Function 'Create rotation' (app function) started
There was an error scheduling the trigger invalid_start_before_now undefined
2023-09-21 12:43:39 [info] [Datastore:rotations] (Trace=Tr05TAAZCNG5) Datastore get succeeded with 'id: C02ARJE6XNU'
2023-09-21 12:43:39 [error] [Fn05TD5T5LH1] (Trace=Tr05TAAZCNG5) Function 'Create rotation' (%!!(MISSING)s(<nil>) function) failed
	invalid_start_before_now
2023-09-21 12:43:40 [error] [Wf05SYNCFQSK] (Trace=Tr05TAAZCNG5) Workflow step 'Create rotation' failed
2023-09-21 12:43:40 [error] [Wf05SYNCFQSK] (Trace=Tr05TAAZCNG5) Workflow 'Manage Rotation' failed
	invalid_start_before_now
2023-09-21 12:43:41 [error] [Fn05TD8P3QQJ] (Trace=Tr05TAAZCNG5) Function 'Manage Rotation' (%!!(MISSING)s(<nil>) function) failed
	invalid_start_before_now

Seems like this error handling code is being triggered.

@filmaj filmaj added the bug Something isn't working label Sep 21, 2023
@misscoded
Copy link
Contributor

misscoded commented Oct 2, 2023

This error is caused when the date and/or time that's selected in the modal is before the current day/time. Also occurs when someone edits the existing rotation and doesn't change the original date/time.

This could be mitigated with form validation either on change or on submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants