Use jalali core #151
Merged
Use jalali core #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashmili
force-pushed
the
use-jalali-core
branch
from
5ce6658
to
fbe715d
Compare
slashmili
force-pushed
the
use-jalali-core
branch
from
fbe715d
to
a084ce3
Compare
hramezani
reviewed
Mar 25, 2024
hramezani
reviewed
Mar 25, 2024
|
I think you should change the version in |
|
Thanks! fixed it. |
hramezani
approved these changes
Mar 25, 2024
slashmili
force-pushed
the
use-jalali-core
branch
from
ad0744d
to
ea31e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to licensing issue raised in #148 , I've decided to take out the LGPL code and release it under a different package called jalali-core.
I'm planning to publish this change as a major release.