-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyodide loading without using beforeInteractive loading strategy #43
Comments
Ah that's rubbish, sorry! Do you see this on desktop browsers or only mobile? I'm only seeing it on iOS (don't have any other devices to check it on), but it seems okay on desktop: runwasm-scroll.movIn terms of loading indicators I did add something very basic for the matplotlib one: runwasm-matplotlib-load.movWe could easily add the But for that one scrolling is frozen (on mobile only for me) during the load pyodide + load matplotlib. I'm wondering if this might be a problem with mobile + useEffect? It's a bit tricky to tell though because we have no visual indicator when that |
Ah okay shouldn't have just assumed it was due to beforeInteractive. I'm only seeing it on iOS mobile safari. |
I made a create-react-app project that has a Out of interest what device are you seeing this on? I'm on an iPhone XR so a few years old. FWIW I can also repro this on a checkout of 74d8565 (the last commit before any of mine today) - site goes unresponsive and won't scroll until the run code button is displayed. |
I'm on iPhone XS 14.71 |
Pretty similar then, probably the same CPU. It’d be good to hear from someone on a newer device or any android device to see if we can narrow it down at all. |
BrowserStack offers free plan for open source projects. This can help in testing across multiple devices |
Using beforeInteractive in the next.js script component fixed the pyodide loading issue but now the experience of using the site is frustrating.
Site does the initial render but you can't scroll until pyodide loads.
Ideally we'd have some sort of loading indicator and let a user scroll on the site instead of making it hang
The text was updated successfully, but these errors were encountered: