Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'branch protection' only applicable for cloud-hosted SCPs? #1136

Open
TomHennen opened this issue Sep 19, 2024 · 3 comments
Open

Is 'branch protection' only applicable for cloud-hosted SCPs? #1136

TomHennen opened this issue Sep 19, 2024 · 3 comments

Comments

@TomHennen
Copy link
Contributor

TomHennen commented Sep 19, 2024

To my knowledge, branch protection is a feature of specific cloud-hosted SCPs, not git/VCS, so I suggest making this requirement for Continuity more generally about the intent/objectives. Then we can maybe just include an example like "This can be achieved using the branch protection features in services like GitHub, for example."

Originally posted by @marcelamelara in #1094 (comment)

@TomHennen
Copy link
Contributor Author

FWIW I think that GitTuf might make this possible outside of a hosted SCP. @adityasaky would know for sure.

@zachariahcox
Copy link
Collaborator

zachariahcox commented Sep 19, 2024

good question!
It's not branded in exactly the same way (because it's way more powerful), but git supports this kind of feature via pre-receive githooks.

The current wording in the pitch is: "On VCS like git, the organization MUST enable branch protections that prohibit updating the branch to point to revisions that are not direct descendants of the current revision."

That does make it sound like there's a button to click somewhere!
We could make it more generic by saying "enforce branch protections."

cc: @marcelamelara

@adityasaky
Copy link
Contributor

adityasaky commented Sep 20, 2024

I think this may in part be addressed with #1128 and #1142. I think #1142 in particular would allow us to set requirements that may be achieved wildly differently depending on what constitutes the source control system as a whole.

As for the rest of it, I think the requirement could use further clarification. The full set of branch protections (whether via an SCP, pre-receive hooks, etc.) could mean quite a bit further than disallowing force pushes and deletions (which are stated as the baseline in the spec atm), so I think clarification is in order as to what the requirement exactly is. Maybe we could reuse this issue for that? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Status: Ready for work!
Development

No branches or pull requests

3 participants